Closed rnbguy closed 3 months ago
Attention: Patch coverage is 88.26896%
with 164 lines
in your changes are missing coverage. Please review.
Project coverage is 66.33%. Comparing base (
05ea5fa
) to head (410b8ad
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Closes: #398
Description
Adds integration tests for combinations of
MockHost
andTendermintHost
.Since it includes
TendermintHost
, these tests also exercise commitment proof validations in Tendermint light clients.The PR also includes a unit test for minimal proof validations.
Additionally, to maintain the
ics23
proof spec, amain_store
is introduced inMockGenericContext
- that stores the IBC store root at IBC commitment prefix path. The blocks are now generated with the root of themain_store
.To keep the proof retrieval minimal, I had to modify the
ProvableContext::get_proof
ofMockIbcStore
. Before it returned the encoded bytes of a singleCommitmentProof
. Now it returns the encoded bytes ofMerkleProofs
, which is essentially a list ofCommitmentProof
s corresponding to aMerklePath
.Two shortcomings of
basecoin_store
:PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.