search

cosmos / ibc-rs

Rust implementation of the Inter-Blockchain Communication (IBC) protocol.
Apache License 2.0
182 stars 74 forks source link

imp(ibc-query): return `MerkleProof` from `ProvableContext::get_proof` #1148

Closed PanGan21 closed 2 months ago

PanGan21 commented 3 months ago

Closes: #1136

Description

Return MerkleProof from ProvableContext::get_proof

PR author checklist:

Reviewer checklist:

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 64.06%. Comparing base (ee1107f) to head (69c4a1a).

Files Patch % Lines
ibc-query/src/core/channel/query.rs 0.00% 8 Missing :warning:
ibc-query/src/core/connection/query.rs 0.00% 5 Missing :warning:
ibc-query/src/core/client/query.rs 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1148 +/- ## ======================================= Coverage 64.06% 64.06% ======================================= Files 217 217 Lines 21049 21049 ======================================= Hits 13484 13484 Misses 7565 7565 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rnbguy commented 3 months ago

Thanks for the PR @PanGan21 ! But this requires consensus if my proposal on the issue is all right.

Please wait until we validate this.

rnbguy commented 2 months ago

hey @PanGan21, sorry we will not make these changes. The main issue that my assumptions from the issues are very Tendermint context-specific. Since ibc-rs is being used in many different host contexts, my suggestion doesn't make sense in a general context.

You can refer to Farhad's comment for more context.

I still appreciate your effort on this PR. Next time, please confirm with us before working on an issue or check if any good-first-issues are available :slightly_smiling_face: :raised_hands: