cosmos / ibc-rs

Rust implementation of the Inter-Blockchain Communication (IBC) protocol.
Apache License 2.0
182 stars 74 forks source link

imp: include `query_height` and `proof` for client upgrade query request/response types #1153

Closed Farhad-Shabani closed 3 months ago

Farhad-Shabani commented 3 months ago

Closes: #1152

Remark

Because of changes in this PR, the domain definition of the QueryUpgradedClient/ConsensusResponse will no longer be identical to their proto definitions. Their TryFrom<raw> has been removed. More context here.


PR author checklist:

Reviewer checklist:

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 71 lines in your changes are missing coverage. Please review.

Project coverage is 63.85%. Comparing base (2b9de34) to head (f510ddd).

Files Patch % Lines
ibc-query/src/core/client/query.rs 0.00% 51 Missing :warning:
ibc-query/src/core/client/service.rs 0.00% 12 Missing :warning:
ibc-query/src/core/client/types/response.rs 0.00% 6 Missing :warning:
ibc-query/src/core/client/types/request.rs 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1153 +/- ## ========================================== - Coverage 63.98% 63.85% -0.14% ========================================== Files 219 219 Lines 21313 21359 +46 ========================================== Hits 13638 13638 - Misses 7675 7721 +46 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.