cosmos / ibc-rs

Rust implementation of the Inter-Blockchain Communication (IBC) protocol.
Apache License 2.0
182 stars 73 forks source link

chore: miscellaneous repository maintenance #1174

Closed rnbguy closed 2 months ago

rnbguy commented 2 months ago

Setting up merge_group is a bit complicated. To auto-remove a PR from merge_group, we need to add them as status_check for merges onto main. But if a job is not executed (because of filtering of paths or trigger events), it will never be added in merge_group - because we need all status checks to be passed before merge.

The merge_group only works for a workflow something as following:

name: Status Check Jobs
on:
  pull_request:
  merge_group:
    types: [checks_requested]

jobs:
  my-job:
    if: ${{ github.event_name != 'pull_request' }}
    steps:
      run: echo "Hello World"

So the workflow is marked as successfully executed on PR, albeit it didn't run any job. When, the PR is put in merge_group, it will actually run my-job.


PR author checklist:

Reviewer checklist:

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.33%. Comparing base (ddd3f48) to head (3bf544b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1174 +/- ## ======================================= Coverage 64.33% 64.33% ======================================= Files 229 229 Lines 22083 22083 ======================================= Hits 14208 14208 Misses 7875 7875 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.