Closed rnbguy closed 2 months ago
Attention: Patch coverage is 51.19048%
with 41 lines
in your changes are missing coverage. Please review.
Project coverage is 64.35%. Comparing base (
d5e3887
) to head (6dc68cf
). Report is 1 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
ibc-clients/cw-context/src/context/mod.rs | 49.29% | 36 Missing :warning: |
ibc-clients/cw-context/src/context/client_ctx.rs | 61.53% | 5 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looks like this fixed CI on https://github.com/informalsystems/hermes/pull/3943, not seeing the error anymore even with super short trusting period 🚀
I will merge this after confirming the latest changes on the Hermes PR :tada:
Tested on personal fork of informalsystems/hermes
using workflow artifact from latest commit. Merging it :rocket:
Note: once hermes is released with wasm client support. basecoin-rs should have an e2e test for wasm clients.
Closes: #1175
This PR also replaces string formatting and parsing with protobuf encoding and decoding.
Description
PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.