cosmos / ibc-rs

Rust implementation of the Inter-Blockchain Communication (IBC) protocol.
Apache License 2.0
182 stars 73 forks source link

fix(cw-context): encoding, decoding and iteration of `ConsensusState` heights #1176

Closed rnbguy closed 2 months ago

rnbguy commented 2 months ago

Closes: #1175

This PR also replaces string formatting and parsing with protobuf encoding and decoding.

Description


PR author checklist:

Reviewer checklist:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 51.19048% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 64.35%. Comparing base (d5e3887) to head (6dc68cf). Report is 1 commits behind head on main.

Files Patch % Lines
ibc-clients/cw-context/src/context/mod.rs 49.29% 36 Missing :warning:
ibc-clients/cw-context/src/context/client_ctx.rs 61.53% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1176 +/- ## ========================================== - Coverage 64.39% 64.35% -0.04% ========================================== Files 230 229 -1 Lines 22053 22081 +28 ========================================== + Hits 14201 14211 +10 - Misses 7852 7870 +18 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

romac commented 2 months ago

Looks like this fixed CI on https://github.com/informalsystems/hermes/pull/3943, not seeing the error anymore even with super short trusting period 🚀

rnbguy commented 2 months ago

I will merge this after confirming the latest changes on the Hermes PR :tada:

rnbguy commented 2 months ago

Tested on personal fork of informalsystems/hermes using workflow artifact from latest commit. Merging it :rocket:

Note: once hermes is released with wasm client support. basecoin-rs should have an e2e test for wasm clients.