cosmos / ibc-rs

Rust implementation of the Inter-Blockchain Communication (IBC) protocol.
Apache License 2.0
182 stars 73 forks source link

fix(ibc-app-nft-transfer): compile without default features #1195

Closed rnbguy closed 2 months ago

rnbguy commented 2 months ago

Closes: #XXX

Description

ibc-app-nft-transfer needs base64 with alloc feature.

check-features was disabled before in favor of status check during merge group checks. But it has some nuances. Refer to #1174's description.


PR author checklist:

Reviewer checklist:

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.33%. Comparing base (d72fb58) to head (43b8113).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1195 +/- ## ======================================= Coverage 64.33% 64.33% ======================================= Files 229 229 Lines 22083 22083 ======================================= Hits 14208 14208 Misses 7875 7875 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.