cosmos / ibc-rs

Rust implementation of the Inter-Blockchain Communication (IBC) protocol.
Apache License 2.0
197 stars 79 forks source link

imp(ibc-client): rm `TryFrom<Error = ClientError>` restriction #1204

Closed rnbguy closed 5 months ago

rnbguy commented 5 months ago

Closes: #1203

Description


PR author checklist:

Reviewer checklist:

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 96.55172% with 2 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (main@ed4f8cd). Click here to learn what that means.

Files Patch % Lines
...nts/ics07-tendermint/src/client_state/execution.rs 83.33% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1204 +/- ## ======================================= Coverage ? 64.43% ======================================= Files ? 229 Lines ? 22041 Branches ? 0 ======================================= Hits ? 14202 Misses ? 7839 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rnbguy commented 5 months ago

Looks like, with this - we can remove types::ClientState and types::ConsensusState usage in ICS-07 and use client_state::ClientState and consensus_state::ConsensusState directly.

This will reduce confusion for downstream users.