Closed rnbguy closed 5 months ago
Attention: Patch coverage is 96.55172%
with 2 lines
in your changes are missing coverage. Please review.
:exclamation: No coverage uploaded for pull request base (
main@ed4f8cd
). Click here to learn what that means.
Files | Patch % | Lines |
---|---|---|
...nts/ics07-tendermint/src/client_state/execution.rs | 83.33% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looks like, with this - we can remove types::ClientState
and types::ConsensusState
usage in ICS-07 and use client_state::ClientState
and consensus_state::ConsensusState
directly.
This will reduce confusion for downstream users.
Closes: #1203
Description
Error = ClientError
inTryFrom
implementations. This preventedTryFrom<Error = Infallible>
from being reused.Convertible
- so thatClientStateDecoder
andConsensusStateDecoder
can be replaced byConvertible<Any>
.PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.