cosmos / ibc-rs

Rust implementation of the Inter-Blockchain Communication (IBC) protocol.
Apache License 2.0
181 stars 73 forks source link

Bump `borsh` to v1 #1245

Closed seanchen1991 closed 1 month ago

seanchen1991 commented 1 month ago

Closes: #1244

Description


PR author checklist:

Reviewer checklist:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 79.41176% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 65.52%. Comparing base (dcf8c36) to head (1b3aed9).

Files Patch % Lines
ibc-core/ics03-connection/types/src/connection.rs 0.00% 3 Missing :warning:
ibc-apps/ics20-transfer/types/src/amount.rs 60.00% 2 Missing :warning:
ibc-core/ics04-channel/types/src/channel.rs 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1245 +/- ## ========================================== - Coverage 65.56% 65.52% -0.05% ========================================== Files 234 234 Lines 23519 23476 -43 ========================================== - Hits 15421 15383 -38 + Misses 8098 8093 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rnbguy commented 1 month ago

Thanks for taking care of this, Sean! Can you open an PR on basecoin side to test this update?