Add missing trait derivations - Githubissues

cosmos / ibc-rs

Rust implementation of the Inter-Blockchain Communication (IBC) protocol.

Apache License 2.0

181 stars 73 forks source link

Add missing trait derivations #1250

Closed larry0x closed 3 weeks ago

larry0x commented 3 weeks ago

Closes: #XXX

Description

The ibc-client-tendermint crate has two optional features: borsh and parity-scale-codec, which are supposed to derive relevant traits. However, these traits are not actually derived. This PR adds the missing derivations.

PR author checklist:

[ ] Added changelog entry, using unclog.
[ ] Added tests.
[ ] Linked to GitHub issue.
[ ] Updated code comments and documentation (e.g., docs/).
[ ] Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

[ ] Reviewed Files changed in the GitHub PR explorer.
[ ] Manually tested (in case integration/unit/mock tests are absent).

larry0x commented 3 weeks ago

I realized this is harder than expected, because this requires several other crates (e.g. tendermint and ics23) also implement Borsh traits.