imp(02-client): implement `TryFrom<TmAbciEvent>` for event types

TropicalDog17 commented 3 weeks ago

Partially addresses: #1220

Description

PR author checklist:

[ ] Added changelog entry, using unclog.
[ ] Added tests.
[ ] Linked to GitHub issue.
[ ] Updated code comments and documentation (e.g., docs/).
[ ] Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

[ ] Reviewed Files changed in the GitHub PR explorer.
[ ] Manually tested (in case integration/unit/mock tests are absent).

TropicalDog17 commented 3 weeks ago

Hey @rnbguy, could you please review my implementation of CreateClient. Before I do the others, I want to make sure I'm on the right track. Thanks.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 80.14706% with 54 lines in your changes missing coverage. Please review.

Project coverage is 67.42%. Comparing base (5dc0b09) to head (7a00527). Report is 3 commits behind head on main.

Files	Patch %	Lines
ibc-core/ics02-client/types/src/events.rs	80.14%	54 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1253 +/- ## ========================================== + Coverage 67.27% 67.42% +0.14% ========================================== Files 235 235 Lines 23538 23811 +273 ========================================== + Hits 15836 16055 +219 - Misses 7702 7756 +54 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

seanchen1991 commented 2 weeks ago

Hey @TropicalDog17, looks like there are a bunch of clippy errors that need addressing. Could you handle those before we circle back for a review on this? 🙏

cosmos / ibc-rs