Open rnbguy opened 2 weeks ago
Attention: Patch coverage is 81.48148%
with 20 lines
in your changes missing coverage. Please review.
Project coverage is 67.34%. Comparing base (
8424f69
) to head (4c0d95f
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
We do need to locally maintain a capability key for each module. Which should be used to authenticate the modules.
This should be unique to each Module type. This is the only way to make sure different modules can't commit packets on the same ports - even though a malicious module tries to forge a Module identifier.
The capability keys shouldn't be committed to the blockchain store - as they are local and probably distinct across different builds. We can use TypeId
for this local capability key - but need to check if using TypeId
is ok from a security perspective.
Closes: #519
ChanOpenInit
andChanOpenTry
.transfer
module can't commit packets for"nft-transfer"
port.""ports/{id}"
.Description
Ref: https://github.com/cosmos/ibc/blob/main/spec/core/ics-005-port-allocation/README.md
PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.