Closed Farhad-Shabani closed 1 month ago
Attention: Patch coverage is 76.13636%
with 63 lines
in your changes missing coverage. Please review.
Project coverage is 67.07%. Comparing base (
7e39192
) to head (ac1ec73
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Closes: #180 Closes: #1296 Closes: #1306
Description
This PR introduces following improvements:
Timestamp
definitions used by the host from those used for timeout purposes. The host timestamp is mandatory, while aNone
value for the timeout timestamp indicates the absence of a timeout.tendermint::Time
, which was also intended fortendermint_proto::google::Timestamp
instead ofibc_proto::google::Timestamp
.tendermint::Time
, laying the groundwork for fully decouplingibc_primitive
from thetendermint
dependency, making it chain-agnostic.tendermint::Time
could produce negative UNIX timestamps, causing a panic when callingTimestamp::nanoseconds()
.TimestampError
typeTimestamp::from_nanoseconds
, as it never fails.PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.