cosmos / ibc-rs

Rust implementation of the Inter-Blockchain Communication (IBC) protocol.
Apache License 2.0
197 stars 79 forks source link

Clean up `ibc-core` and `ibc-clients` error types #1317

Closed seanchen1991 closed 1 month ago

seanchen1991 commented 1 month ago

Part of: #1316

Description


PR author checklist:

Reviewer checklist:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 58.81188% with 208 lines in your changes missing coverage. Please review.

Please upload report for BASE (error-handling@0d98ebf). Learn more about missing BASE report.

Files Patch % Lines
ibc-core/ics25-handler/types/src/msgs.rs 0.00% 19 Missing :warning:
ibc-core/ics23-commitment/types/src/merkle.rs 5.26% 18 Missing :warning:
ibc-clients/ics07-tendermint/types/src/header.rs 60.00% 14 Missing :warning:
ibc-testkit/src/testapp/ibc/core/core_ctx.rs 62.06% 11 Missing :warning:
ibc-core/ics02-client/types/src/events.rs 74.35% 10 Missing :warning:
...ore/ics24-host/cosmos/src/upgrade_proposal/plan.rs 0.00% 9 Missing :warning:
...core/ics24-host/cosmos/src/validate_self_client.rs 0.00% 9 Missing :warning:
ibc-core/ics04-channel/src/handler/timeout.rs 27.27% 8 Missing :warning:
...core/ics04-channel/src/handler/timeout_on_close.rs 46.66% 8 Missing :warning:
...clients/ics07-tendermint/types/src/misbehaviour.rs 41.66% 7 Missing :warning:
... and 37 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## error-handling #1317 +/- ## ================================================= Coverage ? 67.18% ================================================= Files ? 227 Lines ? 23264 Branches ? 0 ================================================= Hits ? 15631 Misses ? 7633 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.