search

cosmos / ibc-rs

Rust implementation of the Inter-Blockchain Communication (IBC) protocol.
Apache License 2.0
206 stars 82 forks source link

imp(ibc-apps): migrate to `DecodingError` in `TryFrom` conversions #1335

Closed Farhad-Shabani closed 2 months ago

Farhad-Shabani commented 2 months ago

Part of: #1330

Description

This PR introduces the migration for the ibc-apps libraries. To simplify the development and review process, issue #1330 will be split across several PRs, with this being the first one.

PR author checklist:

Reviewer checklist:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 43.75000% with 45 lines in your changes missing coverage. Please review.

Please upload report for BASE (error-handling@bfad72f). Learn more about missing BASE report.

Files with missing lines Patch % Lines
ibc-core/ics24-host/types/src/error.rs 42.85% 12 Missing :warning:
ibc-apps/ics20-transfer/types/src/msgs/transfer.rs 0.00% 7 Missing :warning:
ibc-apps/ics721-nft-transfer/types/src/token.rs 22.22% 7 Missing :warning:
ibc-apps/ics721-nft-transfer/types/src/packet.rs 0.00% 5 Missing :warning:
ibc-query/src/error.rs 0.00% 5 Missing :warning:
ibc-apps/ics721-nft-transfer/types/src/class.rs 50.00% 4 Missing :warning:
...pps/ics721-nft-transfer/types/src/msgs/transfer.rs 0.00% 4 Missing :warning:
ibc-apps/ics721-nft-transfer/types/src/data.rs 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## error-handling #1335 +/- ## ================================================= Coverage ? 66.99% ================================================= Files ? 225 Lines ? 22946 Branches ? 0 ================================================= Hits ? 15372 Misses ? 7574 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.