search

cosmos / ibc-rs

Rust implementation of the Inter-Blockchain Communication (IBC) protocol.
Apache License 2.0
206 stars 82 forks source link

Consolidate `PacketError` and `ChannelError` #1343

Closed seanchen1991 closed 2 months ago

seanchen1991 commented 2 months ago

Closes: #1339

Description

PR author checklist:

Reviewer checklist:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 54.28571% with 64 lines in your changes missing coverage. Please review.

Please upload report for BASE (error-handling@6fe0295). Learn more about missing BASE report.

Files with missing lines Patch % Lines
ibc-core/ics04-channel/types/src/channel.rs 65.51% 10 Missing :warning:
ibc-core/ics04-channel/types/src/packet.rs 27.27% 8 Missing :warning:
ibc-testkit/src/testapp/ibc/core/types.rs 0.00% 8 Missing :warning:
...ics04-channel/types/src/msgs/chan_close_confirm.rs 33.33% 6 Missing :warning:
...e/ics04-channel/types/src/msgs/timeout_on_close.rs 54.54% 5 Missing :warning:
ibc-core/ics04-channel/src/handler/recv_packet.rs 33.33% 4 Missing :warning:
ibc-core/ics04-channel/src/handler/timeout.rs 42.85% 4 Missing :warning:
...core/ics04-channel/src/handler/timeout_on_close.rs 42.85% 4 Missing :warning:
...rc/testapp/ibc/applications/nft_transfer/module.rs 0.00% 4 Missing :warning:
ibc-core/ics04-channel/types/src/msgs/timeout.rs 50.00% 3 Missing :warning:
... and 5 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## error-handling #1343 +/- ## ================================================= Coverage ? 66.89% ================================================= Files ? 225 Lines ? 22958 Branches ? 0 ================================================= Hits ? 15357 Misses ? 7601 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.