cosmos / ibc-rs

Rust implementation of the Inter-Blockchain Communication (IBC) protocol.
Apache License 2.0
206 stars 82 forks source link

imp(ibc)!: refactor error handling throughout codebase #1350

Closed seanchen1991 closed 1 month ago

seanchen1991 commented 2 months ago

Closes: #270 Closes: #950 Closes: #1319 Closes: #1320 Closes: #1330 Closes: #1339 Closes: #1346

Description

The branch of this PR is a feature branch that includes changes from the following PRs:


PR author checklist:

Reviewer checklist:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 55.92303% with 733 lines in your changes missing coverage. Please review.

Project coverage is 66.76%. Comparing base (8d36c68) to head (adb5514). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ibc-testkit/src/testapp/ibc/core/core_ctx.rs 64.28% 50 Missing :warning:
...core/ics24-host/cosmos/src/validate_self_client.rs 0.00% 42 Missing :warning:
ibc-core/ics02-client/types/src/events.rs 55.26% 34 Missing :warning:
ibc-core/ics23-commitment/types/src/merkle.rs 4.16% 23 Missing :warning:
ibc-apps/ics721-nft-transfer/src/handler/mod.rs 0.00% 22 Missing :warning:
ibc-apps/ics721-nft-transfer/src/module.rs 23.07% 20 Missing :warning:
ibc-core/ics02-client/types/src/error.rs 28.57% 20 Missing :warning:
ibc-apps/ics20-transfer/src/module.rs 20.83% 19 Missing :warning:
ibc-core/ics25-handler/types/src/msgs.rs 0.00% 19 Missing :warning:
ibc-clients/ics07-tendermint/types/src/header.rs 60.00% 18 Missing :warning:
... and 80 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1350 +/- ## ========================================== + Coverage 66.43% 66.76% +0.33% ========================================== Files 227 225 -2 Lines 23076 22614 -462 ========================================== - Hits 15330 15098 -232 + Misses 7746 7516 -230 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.