Follow-up: ICS 26 routing module

cosmos / ibc-rs

Rust implementation of the Inter-Blockchain Communication (IBC) protocol.

Apache License 2.0

197 stars 80 forks source link

Follow-up: ICS 26 routing module #21

Open hu55a1n1 opened 2 years ago

hu55a1n1 commented 2 years ago

Summary

[ ] Clarify the need for trait object safety in the Router API?
[ ] How do we model ModuleEvent in a chain-agnostic fashion? (see https://github.com/informalsystems/ibc-rs/pull/1838#discussion_r809224893)
[x] Complete WriteAcknowledgement handle impl.

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate milestone (priority) applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

plafer commented 2 years ago

We should also address the TODO in Msg trait:

pub trait Msg: Clone {
    ...
    // TODO: Clarify what is this function supposed to do & its connection to ICS26 routing mod.
    fn route(&self) -> String;

    ...
}