cosmos / ics23

Building generic merkle proof format for IBC
Apache License 2.0
116 stars 68 forks source link

feat: add api folder containing pulsar generated code. #306

Closed DimitrisJim closed 1 month ago

DimitrisJim commented 5 months ago

Required for https://github.com/cosmos/ibc-go/pull/5968#

Protos contain only primitive types so generation was straigh-forward. Would be a good idea to add a step to the go workflow that enters the mod and does a sanity go build ./...

damiannolan commented 5 months ago

Thanks @DimitrisJim!

Happy to leave this open or switch to draft. Likely won't need to merge this if we don't need protov2 and can use gogoproto.

DimitrisJim commented 5 months ago

moving to draft per Damian's comment!

damiannolan commented 1 month ago

This can be closed as pulsar is no longer required. see https://github.com/cosmos/cosmos-sdk/issues/20134