Removing the only consumer chain

cosmos / interchain-security

Interchain Security is an open sourced IBC application which allows cosmos blockchains to lease their proof-of-stake security to one another.

https://cosmos.github.io/interchain-security/

Other

156 stars 126 forks source link

Removing the only consumer chain #122

Closed mpoke closed 2 years ago

mpoke commented 2 years ago

ref.

https://github.com/cosmos/interchain-security/pull/118#discussion_r887888264

what happens theoretically if the unbonding is put on hold while child chains exist, but then child chain gets removed with gov proposal before hold is lifted?

danwt commented 2 years ago

Can we make this issue actionable, or define a closing criteria?

mpoke commented 2 years ago

Can we make this issue actionable, or define a closing criteria?

The implementation should follow the fix in the spec https://github.com/cosmos/ibc/pull/770

mpoke commented 2 years ago

Already fixed by https://github.com/cosmos/interchain-security/blob/d059b86608defeb84fc541db35e93411f15f9d5e/x/ccv/provider/keeper/proposal.go#L84. @danwt Could you please confirm this?

danwt commented 2 years ago

@mpoke just from that line it seems like it. Do you have a situation or complication in mind?

mpoke commented 2 years ago

No, this was the scenario we wanted to handle, i.e., stoping a consumer chain that was the only chain an unbonding op was waiting for.

danwt commented 2 years ago

It seems fine.