Closed bermuell closed 4 months ago
[!NOTE] Currently processing new changes in this PR. This may take a few minutes, please wait...
Commits
Files that changed from the base of the PR and between daf2677928913d068320e36aa98efb0505a2601f and ab219ce184c834d15dfc171f35b83c899eb329c9.Files ignored due to path filters (1)
* `x/ccv/provider/types/tx.pb.go` is excluded by `!**/*.pb.go`Files selected for processing (6)
* proto/interchain_security/ccv/provider/v1/tx.proto (3 hunks) * tests/e2e/steps_consumer_misbehaviour.go (1 hunks) * tests/e2e/steps_partial_set_security.go (13 hunks) * x/ccv/provider/client/cli/tx.go (2 hunks) * x/ccv/provider/handler.go (1 hunks) * x/ccv/provider/types/msg.go (2 hunks)________________________________________________ < Press W-A-S-D to move me around your codebase. > ------------------------------------------------ \ \ (\__/) (•ㅅ•) / づ
The changes involve updating the Status
field in various test files from string literals to integer values. This is achieved by converting the enum values to strings using strconv.Itoa
. The modifications likely enhance type safety and consistency in handling status values related to proposals.
File Path | Change Summary |
---|---|
tests/e2e/steps_consumer_misbehaviour.go |
Updated Status field from string to integer using strconv.Itoa for PROPOSAL_STATUS_VOTING_PERIOD . |
tests/e2e/steps_partial_set_security.go |
Updated Status field from string to integer using strconv.Itoa for various statuses. Added import for strconv . |
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Hey, is the PSS test on this branch working for you? It doesn't for me. When I run
go run ./tests/e2e/... --tc partial-set-security-opt-in
it gives me
...
running default: step 3/23 == OptInAction
2024/06/03 08:27:27 exit status 1
Usage:
simd tx provider opt-in [consumer-chain-id] [consumer-pubkey] [flags]
...
rpc error: code = Unknown desc = rpc error: code = Unknown desc = no cosmos.msg.v1.signer option found for message interchain_security.ccv.provider.v1.MsgOptIn; use DefineCustomGetSigners to specify a custom getter with gas used: '0': unknown request
exit status 1
Not saying this needs to be fixed in this PR, just curious if that's also happening on your end
Hey, is the PSS test on this branch working for you? It doesn't for me. When I run
go run ./tests/e2e/... --tc partial-set-security-opt-in
it gives me
... running default: step 3/23 == OptInAction 2024/06/03 08:27:27 exit status 1 Usage: simd tx provider opt-in [consumer-chain-id] [consumer-pubkey] [flags] ... rpc error: code = Unknown desc = rpc error: code = Unknown desc = no cosmos.msg.v1.signer option found for message interchain_security.ccv.provider.v1.MsgOptIn; use DefineCustomGetSigners to specify a custom getter with gas used: '0': unknown request exit status 1
Not saying this needs to be fixed in this PR, just curious if that's also happening on your end
It was failing as well.
But I was working on that and the latest commit to this PR fixes it.
partial-set-security-opt-in
test is passing now
Description
fix e2e tests
PROPOSAL_STATUS_*
returning integer value in string representation starting from SDK v0.50Author Checklist
All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...
Summary by CodeRabbit