Closed insumity closed 4 months ago
[!NOTE] Currently processing new changes in this PR. This may take a few minutes, please wait...
Commits
Files that changed from the base of the PR and between e0775d92395fa88915edeaeaf634484bf8af7fa3 and 1c62d65d50b2d1ae9a87b35870d0113d8f0169ac.Files selected for processing (2)
* x/ccv/provider/types/proposal.go (4 hunks) * x/ccv/provider/types/proposal_test.go (2 hunks)____________________________________________________________________________________________________________________________________ < Put abstractions in code, details in metadata. Program for the general case, and put the specifics outside the compiled code base. > ------------------------------------------------------------------------------------------------------------------------------------ \ \ (\__/) (•ㅅ•) / づ
The recent changes introduce a new proposal type, ConsumerModificationProposal
, to the interchain security provider module. This proposal allows for governance-based modifications of parameters for running consumer chains, including validator settings and allow/deny lists. The changes span multiple files, adding new message types, handlers, validation functions, and test cases to support this functionality.
Files | Change Summaries |
---|---|
proto/.../provider/v1/provider.proto |
Added ConsumerModificationProposal message with fields for modifying consumer chain parameters. |
x/ccv/provider/client/proposal_handler.go |
Introduced handler, command, and JSON parsing for ConsumerModificationProposal . |
x/ccv/provider/keeper/proposal.go |
Added HandleConsumerModificationProposal function to manage proposal processing. |
x/ccv/provider/keeper/proposal_test.go |
Added tests for HandleConsumerModificationProposal function. |
x/ccv/provider/proposal_handler.go |
Updated NewProviderProposalHandler to include ConsumerModificationProposal . |
x/ccv/provider/types/codec.go |
Registered ConsumerModificationProposal with the InterfaceRegistry . |
x/ccv/provider/types/errors.go |
Added ErrInvalidConsumerModificationProposal error. |
x/ccv/provider/types/proposal.go |
Added ConsumerModificationProposal type, functions, and validations. |
x/ccv/provider/types/proposal_test.go |
Added test cases for ConsumerModificationProposal validation functions. |
sequenceDiagram
participant Governance
participant ProposalHandler
participant Keeper
participant ConsumerChain
Governance->>ProposalHandler: Submit ConsumerModificationProposal
ProposalHandler->>Keeper: HandleConsumerModificationProposal
Keeper->>ConsumerChain: Update Parameters (top_N, validators_power_cap, etc.)
ConsumerChain->>Keeper: Confirmation of Updates
Keeper->>ProposalHandler: Proposal Processed
ProposalHandler->>Governance: Proposal Result
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
LGTM! Just one nit.
Description
This PR introduces the
ConsumerModificationProposal
that allows consumer chains to change PSS parameters (e.g.,topN
,validatorSetCap
, etc.) while a consumer chain is running.Note that a validator that was automatically opted in on a Top N consumer chain would remain opted in even after moving to an Opt In chain.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.
I have...
!
to the type prefix if the change is state-machine breakingCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...
!
the type prefix if the change is state-machine breakingSummary by CodeRabbit
New Features
ConsumerModificationProposal
, allowing modifications to parameters of a running consumer chain.Bug Fixes
Tests
ConsumerModificationProposal
to ensure proper validation and functionality.Documentation