Closed insumity closed 3 months ago
tests/e2e/actions.go (2)
Pattern `**/*.go`: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations. --- Pattern `tests/e2e/*`: "Assess the e2e test code assessing sufficient code coverage for the changes associated in the pull request"
tests/e2e/actions.go
2179-2179: string `auto` has 3 occurrences, make it a constant (goconst)
Description
Closes: #1927
Problem After the release of Partial Set Security in Gaia v17, the Soft Opt-Out feature is not needed anymore because the only registered consumer chains (i.e., Stride and Neutron) have become Top 95% consumer chains. This means that the last 5% of the Cosmos Hub validators do not have to validate a consumer chain unless they choose to do so by sending a
MsgOptIn
message. Nevertheless, Soft Opt-Out is still functional in Gaia v17, and as a result, the last 5% of the top 95% validators could choose to not validate Stride or Neutron without getting jailed.Solution This PR removes the Soft Opt-Out feature.
The
soft_opt_out_threshold
is used as a parameter in the consumer genesis files, so to be backwards compatible with older-version consumer modules, we do not rename or remove thesoft_opt_out_threshold
and just set it to0
.We also deprecate the storage under
SmallestNonOptOutPowerByteKey
on the consumer module but we do not delete the values that were stored for Stride and Neutron. To actually delete the stored soft opt-out values, we would need migration code and it did not seem that is worth it to introduce migration code to reclaim2 * size(int64) = 16 bytes
. If there are concerns, I can add the migration code for this.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.
I have...
!
to the type prefix if the change is state-machine breakingCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...
!
the type prefix if the change is state-machine breakingSummary by CodeRabbit
Deprecations
Bug Fixes
SoftOptOutThreshold
parameter to zero in the consumer app genesis.Documentation
Tests