fix: allow the owner of a chain to remove the chain

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.

I have...

[ ] Included the correct type prefix in the PR title
[ ] Added ! to the type prefix if the change is state-machine breaking
[ ] Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
[ ] Targeted the correct branch (see PR Targeting)
[ ] Provided a link to the relevant issue or specification
[ ] Followed the guidelines for building SDK modules
[ ] Included the necessary unit and integration tests
[ ] Added a changelog entry to CHANGELOG.md
[ ] Included comments for documenting Go code
[ ] Updated the relevant documentation or specification
[ ] Reviewed "Files changed" and left comments if necessary
[ ] Confirmed all CI checks have passed
[ ] If this PR is library API breaking, bump the go.mod version string of the repo, and follow through on a new major release

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed ! the type prefix if the change is state-machine breaking
[ ] confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
[ ] confirmed all author checklist items have been addressed
[ ] reviewed state machine logic
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage

Summary by CodeRabbit

New Features
- Enhanced the message structure for removing consumer chains by renaming the authority field to signer, improving clarity and flexibility.
- Implemented a more robust validation process for the removal of consumer chains, ensuring that only legitimate owners can perform the action.
Bug Fixes
- Improved error handling for owner address retrieval in the consumer removal process, enhancing overall security.

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

## Walkthrough The changes involve updates to the `MsgRemoveConsumer` message structure, specifically renaming the `authority` field to `signer` for enhanced clarity. The `RemoveConsumer` method in the `msgServer` struct has been modified to implement a more detailed validation process, ensuring that only the legitimate owner can remove a consumer by verifying the message signer against the owner address. These adjustments aim to improve the overall message structure and security. ## Changes | Files | Change Summary | |--------------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------| | `proto/interchain_security/ccv/provider/v1/tx.proto`, `x/ccv/provider/types/msg.go` | Renamed `authority` to `signer` in the `MsgRemoveConsumer` message structure and updated related functions to reflect this change. | | `x/ccv/provider/keeper/msg_server.go` | Enhanced the `RemoveConsumer` method to validate the message signer against the retrieved owner address instead of a simple authority check, adding error handling. | ## Sequence Diagram(s) ```mermaid sequenceDiagram participant User participant MsgServer participant ConsumerDB User->>MsgServer: RemoveConsumer(msg) MsgServer->>ConsumerDB: RetrieveOwnerAddress(consumerId) alt Owner Address Found MsgServer->>MsgServer: Validate signer == owner address alt Valid Signer MsgServer->>ConsumerDB: RemoveConsumer(consumerId) MsgServer-->>User: Success Response else Invalid Signer MsgServer-->>User: Error Response (Invalid Signer) end else Owner Address Not Found MsgServer-->>User: Error Response (Owner Not Found) end ```

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

cosmos / interchain-security