search

cosmos / interchain-security

Interchain Security is an open sourced IBC application which allows cosmos blockchains to lease their proof-of-stake security to one another.
https://cosmos.github.io/interchain-security/
Other
156 stars 127 forks source link

Diff test setup seems incorrect #411

Closed shaspitz closed 2 years ago

shaspitz commented 2 years ago

Problem

In places such as CreateConsumerClient, the IBC ClientState.UnbondingPeriod is set to the unbonding period of the counterparty chain, not the native unbonding period.

In diff tests, the client state unbonding period for the provider is set to the unbonding period for the provider.

One of two places is incorrect, and judging by the TODO in the diff test code, there might be a deeper issue with how unbonding periods are configured.

I'm running into such issues while developing #410, so it may be useful to fix diff tests separately from that PR

Closing criteria

Fix discrepancy between diff tests and other uses of client state unbonding period

TODOs

danwt commented 2 years ago

Thanks, this should be addressed by https://github.com/cosmos/interchain-security/pull/412