Remove template_client from CCV provider genesis

[MSalopek]

Problem

template_client field should be removed from provider genesis.

Closing criteria

The field is removed from provider genesis.

TODOs

• [x] Labels have been added for issue
• [x] Issue has been added to the ICS project

[MSalopek]

After inspecting the code, it seems the changes requested have become state breaking (correct me if I'm wrong, it happens).

This is the code.

And here an excerpt:

// Params defines the parameters for CCV Provider module
message Params {
  ibc.lightclients.tendermint.v1.ClientState template_client = 1; // removing this changes the proto field ids of all param fields
  string trusting_period_fraction = 2;
  ...
}

This can cause incompatibility between versions and require a migration of provider state because we would have to migrate the params.

EDIT: will look a bit deeper.

[yaruwangway]

Hi @MSalopek , yes, removal of template_client from params is state-breaking. which need a state migration.

[yaruwangway]

why remove template_client ?

[MSalopek]

Putting it to blocked until we establish if and how to remove this.

Since the issue is older, this may not be feasible any more. We should avoid state breaking changes, and be careful about backporting features to previous and current releases.

Issue will be closed if it is no longer needed.

Thanks @yaruwangway for checking this out!

EDIT: removed "good first issue" label since the change may be state breaking.