search

cosmos / interchain-security

Interchain Security is an open sourced IBC application which allows cosmos blockchains to lease their proof-of-stake security to one another.
https://cosmos.github.io/interchain-security/
Other
156 stars 127 forks source link

Fork modified cosmos-sdk modules and add them to this repo #68

Closed mpoke closed 2 years ago

mpoke commented 2 years ago

Currently, the Interchain Security branch is https://github.com/cosmos/cosmos-sdk/tree/interchain-security-rebase

Update: https://github.com/cosmos/interchain-security/issues/68#issuecomment-1125976598

Dependencies:

mpoke commented 2 years ago

After discussions within the team, we decided to not merge the Cosmos SDK changes to the master branch, but rather fork the relevant Cosmos SDK modules and add them directly to the interchain-security repo, similarly to https://github.com/iqlusioninc/liquidity-staking-module/tree/master/x

mpoke commented 2 years ago

@okwme What is the latest view on this issue? What's the preferred way to go about it?

  1. Keep own branch on cosmos-sdk, i.e., https://github.com/cosmos/cosmos-sdk/tree/interchain-security-rebase.
  2. Move the relevant SDK modules to the interchain-security repo.
  3. Merge the changes to the main SDK branch.
jtremback commented 2 years ago

This is settled, right @mpoke? Reopen if not.

mpoke commented 2 years ago

Yes. The SDK changes need by IS will be merge to the main SDK branch and eventually be part of a new SDK release (e.g., 0.47). See https://github.com/cosmos/cosmos-sdk/pull/13122