cosmos / interchain-security

Interchain Security is an open sourced IBC application which allows cosmos blockchains to lease their proof-of-stake security to one another.
https://cosmos.github.io/interchain-security/
Other
156 stars 126 forks source link

Make consumer chain governance whitelist #82

Closed mpoke closed 2 years ago

mpoke commented 2 years ago

By default, the consumer chain should not be able to change any parameter. Every consumer chain can whitelist some parameters, which need to be approved by the provider chain while voting on the governance proposal to accept the consumer chain.

Do we need to whitelist some parameters by default?

This issue is related to https://github.com/cosmos/interchain-security/issues/81

mpoke commented 2 years ago

Needed for the democracy package (where the gov module is enabled on the consumer)

tac0turtle commented 2 years ago

This is optional? like a consumer chain doesn't have to do this, right

mpoke commented 2 years ago

This is optional? like a consumer chain doesn't have to do this, right

The part "By default, the consumer chain should not be able to change any parameter." is needed for security guarantees. Whitelisting some params may be necessary to enable the consumer chain to use the governance module. Governance is used to change the binary or to update some params, right? Without whitelisting params, only the former will be possible.

Nonetheless, this issue has low priority. We can always whitelist params once a consumer chain requests them.

jtremback commented 2 years ago

Closing this in favor of #284