Improve Tx review (fees)

cosmos / ledger-cosmos-obsolete

Ledger Nano S support for Tendermint/Cosmos

Apache License 2.0

42 stars 29 forks source link

Improve Tx review (fees) #141

Closed jleni closed 4 years ago

jleni commented 5 years ago

Improve the way transaction fees and amounts are represented when reviewing transaction. Improve JSON parser to understand these fees/amounts/denominations. Add a menu to allow selecting units are atoms or uatoms.

jleni commented 4 years ago

This has been included as part of: https://github.com/LedgerHQ/ledger-app-cosmos/pull/8 https://github.com/LedgerHQ/ledger-app-cosmos/pull/9

The only feature that has not been included is the menu to select units. This could be problematic because the Cosmos app operates in a generic way so any possible unit can be used. I will close this issue and reopen one to for the specific menu option (https://github.com/cosmos/ledger-cosmos/issues/158)