cosmos / ledger-cosmos

Apache License 2.0
53 stars 108 forks source link

Ledger: Fail to send token: Data is invalid : Unrecognized error code #65

Closed chmichael closed 2 years ago

chmichael commented 2 years ago

After updating the cosmos app on the ledger i can't send through IBC. I throws: Fail to send token: Data is invalid : Unrecognized error code

To Reproduce Steps to reproduce the behavior:

Update your ledger device with the latest cosmos app
From keprl go to osmosis chain
Select an IBC token (eg. Juno) and sent it to another Osmosis address (don't use IBC transfer, click on the asset!)
You'll get Fail to send token: Data is invalid : Unrecognized error code

Before the update of the cosmos app on ledger it worked. Anyhow only the IBC transfer doesn't work the the updated cosmos app on ledger.

Expected behavior To send the token to the other address

So something has changed either from the cosmos ledger app or the keprl.

Thank you

Reported the same issue on Keprl's github they think it's your issue: https://github.com/chainapsis/keplr-wallet/issues/368

Thanks

akrueger commented 2 years ago

I also have this issue with Terra IBC tokens (SCRT, OSMO, ATOM) when sending between two Terra wallets.

Also reported this to Keplr team and they feel it's the Ledger Cosmos app.

mrlp4 commented 2 years ago

I had the same issue, and after some discovering with osmosis cli i found up that cosmos app on ledger wont accept token denom longer that 49 symbols. I found that it only related to transfer transaction, swap or IBC send works well. Got it confirmed with multiple chains - Juno, Osmosis, Bostrom. At every one native tokens (with short denom) sends work, wile non-native dont.
Everything works well with 2.18.0 cosmos app Does not work with 2.34.4 app on either x or s ledger on latest firmware.

chmichael commented 2 years ago

The problem is that we can not revert back until the fix it!

intercos commented 2 years ago

The issue of IBC token send impossible It's definitely something to do with the Cosmos App update. https://github.com/chainapsis/keplr-wallet/issues/368#issuecomment-1145385768

chmichael commented 2 years ago

Can anybody fix it please ? Devs seems not looking the "issue" list!

Thank you

Terminal-Geek commented 2 years ago

This bug makes it impossible, to supply any IBC assets to Kava lend or to withdraw. So my Atom is stuck there. Please fix.

ledger_ibc_bug
wickles commented 2 years ago

Cameron from Kava Labs has been saying that they have posted a PR to fix this over a month ago but it has not been accepted yet. I have not been able to find that PR but he claims the Kava team has been in contact with the Ledger team about it. It seems like there is some seriously poor communication between the teams in resolving this issue. Please get it together. @Kava-Labs @LedgerHQ @Zondax

Screen Shot 2022-06-05 at 10 11 22 AM Screen Shot 2022-06-05 at 10 14 44 AM
chmichael commented 2 years ago

@ftheirs @Saltari Anyone of you alive or dead ? We need a FUCKING FIX for GOD SAKE!

Thank you

Terminal-Geek commented 2 years ago

PUSH! Any news about this?

Cameron from Kava Labs has been saying that they have posted a PR to fix this over a month ago but it has not been accepted yet. I have not been able to find that PR but he claims the Kava team has been in contact with the Ledger team about it. It seems like there is some seriously poor communication between the teams in resolving this issue. Please get it together. @Kava-Labs @LedgerHQ @Zondax

Screen Shot 2022-06-05 at 10 11 22 AM Screen Shot 2022-06-05 at 10 14 44 AM
penguinpablo commented 2 years ago

I have been waiting for a solution for a month now. Can someone pick this up please? My ATOM tokens are stuck on Kava due to this issue.

mrlp4 commented 2 years ago

I have been waiting for a solution for a month now. Can someone pick this up please? My ATOM tokens are stuck on Kava due to this issue.

dude, i'm not a dev here, but can advice you to do IBC transfer instead of normal transfer it works for me when i send atoms in osmosis

ftheirs commented 2 years ago

Hi everyone! We've made some fixes for IBC and the release is published here: https://github.com/cosmos/ledger-cosmos/releases/tag/v2.34.5

You can install Zondax release only in NanoS and NanoS+:

We are working to publish a new Ledger official release!

chmichael commented 2 years ago

THANKKKKK YOOOUUUUUUUU!!! Finallyyyyyyyyyyyy!!!! 💯 🥳

Don't forget NanoX!

Terminal-Geek commented 2 years ago

Hi everyone! We've made some fixes for IBC and the release is published here: https://github.com/cosmos/ledger-cosmos/releases/tag/v2.34.5

You can install Zondax release only in NanoS and NanoS+:

  • Download installer_nanos.sh (or nanos_plus depending on your device)

  • Give execution permission (chmod +x installer_nanos.sh)

  • Install version 2.34.5 (./installer_nanos.sh load) ---> This will uninstall previous version and then install 2.34.5

We are working to publish a new Ledger official release!

Thank you, looking forward the public release. Do you have an ETA?

Regards

ftheirs commented 2 years ago

I will close this issue since it's duplicated. Conversation can be followed here https://github.com/cosmos/ledger-cosmos/issues/66 However, it's a matter of time to get a new cosmos release published by Ledger.