search

cosmos / relayer

An IBC relayer for ibc-go
Apache License 2.0
390 stars 1.71k forks source link

add `trust_level` numerator and denominator as flag when creating a client #1456

Open boojamya opened 6 months ago

boojamya commented 6 months ago

The go relayer has a lot of overrides when it comes to creating a client (--client-tp, --client-unbonding-period, --max-clock-drift, ect). But it's missing one... trust_level.

I ran into this issue recently (screenshot attached).

In the intermittent I've hacked the relayer to give me the proper trust_level, but I do think this would be a great addition.

My initial thoughts are that this should only be added to rly tx client and not rly tx clients.

Screenshot 2024-04-25 at 4 14 39 PM

jtieri commented 6 months ago

hey @boojamya!!

good call out, it would be nice to get this added to the rly tx client command. we could probably add it to both rly tx client and rly tx clients in case users want to use the same value for both clients, but we probably want to add some docs that make this behavior clear.

at this point it could be beneficial to add a document on client initialization to the docs directory that explains all of the flags that can be used during light client initialization.

is this something you would want to work on getting a PR up for?