cosmos / relayer

An IBC relayer for ibc-go
Apache License 2.0
390 stars 1.71k forks source link

feat: add separate flag for metrics #1504

Closed AntiTyping closed 3 weeks ago

AntiTyping commented 2 months ago

Refactors debug and metrics servers into two separate servers

freak12techno commented 2 months ago

Just saying, 9100 is a default port for node_exporter, which is widely used everywhere for HW metrics collection, so it might clash.

jtieri commented 1 month ago

Did we still want to ensure backwards compatibility in this PR by adding back the old flags/old fields in the config, and then mark things deprecated for one release?

If not then i think this is mostly ready to merge and we can just cut a new major release

AntiTyping commented 1 month ago

@jtieri I restored the legacy flags and settings in this commit https://github.com/cosmos/relayer/pull/1504/commits/6cb53dcd407683e39d5fec051156fbaf2779b894