search

cosmos / solidity-ibc-eureka

This is a work-in-progress solidity implementation of IBC Eureka.
MIT License
26 stars 2 forks source link

sdkCoin testing enhancement #28

Closed sangier closed 2 months ago

sangier commented 3 months ago

This PR provides several enhancements of the test file with table testing and invariant testing. Additionally it provides small refactors for the SdkCoin library.

sangier commented 2 months ago

Thank you so much @srdtrk. These kind of comments are really important to me as they help enhancing my engineering practices. <3

sangier commented 2 months ago

Review comments addressed, we should be good to go!

srdtrk commented 2 months ago

Sounds good, I'll review again. FYI, you can request a review once everything is done on the top right