search

cosmos / solidity-ibc-eureka

This is a work-in-progress solidity implementation of IBC Eureka.
MIT License
12 stars 2 forks source link

Change sdkCoin functions names to camelCase #32

Closed sangier closed 3 weeks ago

sangier commented 1 month ago

_ERC20ToSdkCoin_ConvertAmount and _SdkCoinToERC20_ConvertAmount should be in camelCase format to account for standards used in libraries. So change to the name to convertAmountERC20ToSdkCoin and convertAmountSdkCoinToERC20 taking into account any place where they are used.

MukulKolpe commented 4 weeks ago

Hey @crodriguezvega, can I work on this one?

crodriguezvega commented 4 weeks ago

Hi @MukulKolpe. Yes, thank you! I will assign it to you.

crodriguezvega commented 3 weeks ago

Superseded by #55