cosmos / solidity-ibc-eureka

This is a work-in-progress solidity implementation of IBC Eureka.
MIT License
12 stars 2 forks source link

SdkCoin Library Integration (Solidity-Only) #34

Closed sangier closed 1 month ago

sangier commented 1 month ago

Closes https://github.com/srdtrk/solidity-ibc-eureka/issues/27

I have depicted this diagram to help the reasoning. The 18 EVM decimals are used as an example. Hopefully, this can be useful to understand why I have implemented stuff in this way and the changes applied to IBCERC20. More than happy to receive feedbacks on the integration strategy!

EVM_SdkCoin_Conversion

I have noted that the current tests covers a limited set of inputs. IMO we should open issues to add more coverage/testing strategy in a separate PRs as in here.

E2e probably need to be fixed with new amounts.