In ICS20Transfer.sol we have two functions that "unwrap" (and more) the packet data: _unwrapSendPacketData() and _unwrapReceivePacketData().
They are hard to read and reason about, and if we could find a better way to handle all the logic it contains, it would be a big improvement to the ICS20Transfer code.
The UnwrappedPacketData has become big, complex and contains a lot of information that might be better suited elsewhere (some fields might just be kept local since they are not used many places, like the originatorChainIsSource field).
In
ICS20Transfer.solwe have two functions that "unwrap" (and more) the packet data:_unwrapSendPacketData()and_unwrapReceivePacketData().They are hard to read and reason about, and if we could find a better way to handle all the logic it contains, it would be a big improvement to the ICS20Transfer code.
The
UnwrappedPacketDatahas become big, complex and contains a lot of information that might be better suited elsewhere (some fields might just be kept local since they are not used many places, like theoriginatorChainIsSourcefield).