cosmos / solidity-ibc-eureka

This is a work-in-progress solidity implementation of IBC Eureka.
MIT License
26 stars 2 forks source link

Use auto-generated code/ABI for marshalling Packet in e2e fixtures #46

Open gjermundgaraba opened 2 months ago

gjermundgaraba commented 2 months ago

The Packet that is marshalled in the e2e fixture is currently manually created by creating a new ABI type. This would cause issues if Packet struct ever changes (and might only give errors later when the fixtures are used in the solidity tests).

The ideal solution here would be to use something that is generated from the solidity code. Perhaps there is a way to use the ABI from ICS26Router to get the struct from there.

Reference to the discussion: https://github.com/cosmos/solidity-ibc-eureka/pull/44#discussion_r1720609744