search

cosmos / solidity-ibc-eureka

This is a work-in-progress solidity implementation of IBC Eureka.
MIT License
12 stars 2 forks source link

refactor: renamed sdkCoin functions to camelCase #50

Closed MukulKolpe closed 3 weeks ago

MukulKolpe commented 4 weeks ago

Updated _ERC20ToSdkCoin_ConvertAmount and _SdkCoinToERC20_ConvertAmount to convertAmountFromERC20 and convertAmountToERC20 respectively, aligning them with standard camelCase naming convention to account for standards used in libraries.

closes: #32

gjermundgaraba commented 4 weeks ago

@MukulKolpe, I just checked it out locally, and I guess the e2e fails are due to an issue in our CI pipeline with some secrets not being able to run. I ran one of the e2e tests myself, so I believe when everything else is fixed here this can be merged anyway :)

srdtrk commented 4 weeks ago

Yes, created an issue (https://github.com/cosmos/solidity-ibc-eureka/issues/54) about this @gjermundgaraba, we can merge this PR without the e2es passing

MukulKolpe commented 4 weeks ago

Thanks @gjermundgaraba, @srdtrk!

gjermundgaraba commented 4 weeks ago

@MukulKolpe, it looks like it is failing on the listing. Try to run just lint locally and implement the suggested changes :)

crodriguezvega commented 3 weeks ago

Thank you for the PR, @MukulKolpe, but at the end it turned out that we don't need this SDK coin library, so it will be removed.