cosmos / sp1-ics07-tendermint

This is a zero knowledge IBC tendermint light client written using SP1 and ibc-rs (WIP)
MIT License
20 stars 3 forks source link

Migrate elf files from committed binaries to be ci-built and stored artifacts #85

Closed gjermundgaraba closed 1 month ago

gjermundgaraba commented 1 month ago

Currently, we commit new versions of the elf files to the repo, but they are multiple megabytes that we add to the git history every time we do this. Over time this will bloat the history and cloning the repo will become slow/expensive (because binary files typically doesn't diff well). Merge conflicts also become more cumbersome as you will have to rebuild the artefacts after every merge of them.

The clean solution is to remove them from the repo and instead build them in CI, store them in an artefact repository and download them for the e2e tests. The simplest solution is probably to use the official GitHub Actions as described in: https://docs.github.com/en/actions/using-workflows/storing-workflow-data-as-artifacts