search

cosmos / wallet-registry

Creative Commons Attribution 4.0 International
1 stars 10 forks source link

Rename 'platform' property? #11

Open JeremyParish69 opened 1 year ago

JeremyParish69 commented 1 year ago

Looking for second opinions on whether to rename to "platform" property.

I argue that it is confusing because currently the platforms array is used to contain all 'platforms' (device + type (app vs browser) + platform (operating system or browser))

E.g., 

  "platforms": [
    {
      "device": "mobile",
      "type": "application",
      "platform": "ios",
      "install_link": "apple/app-store.com/cryptowallet",
    },

I think it's confusing to use the same word 'platform' to describe both the operating system (or broswer) and also the combination of all three properties in an object.

I might propose changing platform to system, which, granted, applied better to operating system and maybe not so well to browser names. product or variant might also work... e.g., 

  "platforms": [
    {
      "device": "mobile",
      "type": "application",
      "product": "ios",
      "install_link": "apple/app-store.com/cryptowallet",
    },

Or alternatively, changing platforms to environments. e.g., 

  "environments": [
    {
      "device": "mobile",
      "type": "application",
      "platform": "ios",
      "install_link": "apple/app-store.com/cryptowallet",
    },