search

cosmoscout / cosmoscout-vr

:milky_way: A virtual universe which lets you explore, analyze and present huge planetary datasets and large simulation data in real-time.
Other
354 stars 27 forks source link

Loading a new settings.json using deferred loading does not load specified bookmarks etc. #261

Closed NXXR closed 3 years ago

NXXR commented 3 years ago

Describe the Bug

The callback CosmoScout.callbacks.core.load only loads changed plugins, but not changed bookmarks etc. image

Steps to reproduce the behavior:

  1. Start CosmoScout
  2. Use CosmoScout.callbacks.core.load("settings.json") with a settings.json file with different/additional bookmarks
  3. Bookmarks do not appear in the Bookmarks List and Plugins requiring Bookmarks (i.e. csp-user-study) crash.

Expected Behavior

Loading a new settings file should also check and import defined bookmarks, not just check for changed plugins.

System

NXXR commented 3 years ago

@Schneegans @JonasGilg

NXXR commented 3 years ago

Issue found, error was within my plugin. Bookmarks are reloaded at the very beginning of the deferred loading process.