Simple Eclipses

[Schneegans]

New Features:

• Eclipse shadows cast by spherical bodies without incorporation of atmospheric effects
• Oren-Nayar shading for simple bodies
• Higher-resolution Jupiter texture
• HDR image file format support for the texture loader
• Gamma-only tone mapping operator

The eclipse shadow texture generator will be added in another pull request.

[coveralls]

Pull Request Test Coverage Report for Build 2419857834

• 16 of 199 (8.04%) changed or added relevant lines in 12 files are covered.
• 8 unchanged lines in 4 files lost coverage.
• Overall coverage increased (+0.02%) to 3.016%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
plugins/csp-atmospheres/src/Atmosphere.cpp	0	2	0.0%
plugins/csp-lod-bodies/src/LodBody.cpp	0	2	0.0%
plugins/csp-atmospheres/src/Plugin.cpp	0	4	0.0%
plugins/csp-atmospheres/src/AtmosphereRenderer.cpp	16	21	76.19%
src/cs-core/Settings.cpp	0	10	0.0%
src/cs-graphics/TextureLoader.cpp	0	12	0.0%
src/cs-core/GraphicsEngine.cpp	0	13	0.0%
plugins/csp-simple-bodies/src/SimpleBody.cpp	0	15	0.0%
plugins/csp-lod-bodies/src/PlanetShader.cpp	0	16	0.0%
src/cs-core/SolarSystem.cpp	0	22	0.0%
<!--	Total:	16	199	8.04%	-->

Files with Coverage Reduction	New Missed Lines	%
plugins/csp-atmospheres/src/Atmosphere.cpp	1	0%
plugins/csp-simple-bodies/src/SimpleBody.cpp	2	0%
src/cs-core/Settings.cpp	2	0%
plugins/csp-lod-bodies/src/PlanetShader.cpp	3	0%
<!--	Total:	8		-->

Totals
Change from base Build 2294033862:	0.02%
Covered Lines:	496
Relevant Lines:	16447

---

💛 - Coveralls

[JonasGilg]

There seems to be an error towards the start and end of eclipses. From one second to another the shadow disappears completely. Below are two example pictures one second after the other:

If you toggle between them in an image viewer or in CosmoScout you can see, that the shadow diappears abruptly, instead of smoothly.

[JonasGilg]

If you toggle between them in an image viewer or in CosmoScout you can see, that the shadow diappears abruptly, instead of smoothly.

Another example would be 2006-03-29 12:17:51 + 12:17:52 over central Asia.

[Schneegans]

Thanks for discovering this! There was indeed a bug in the CPU-side identification of potential eclipse shadow casters (the Sun had a radius of zero..). Now it should be working!