search

cosmoscout / cosmoscout-vr

:milky_way: A virtual universe which lets you explore, analyze and present huge planetary datasets and large simulation data in real-time.
Other
351 stars 27 forks source link

Rings as Eclipse Shadow Receiver #281

Closed JonasGilg closed 2 years ago

JonasGilg commented 2 years ago

It would be nice, if rings also receive eclipse shadows.

JonasGilg commented 2 years ago

I tried implementing this feature, but sadly it is not as trivial as I thought, since there is a check for self shadowing, that just compares the center names here: https://github.com/cosmoscout/cosmoscout-vr/blob/develop/src/cs-core/SolarSystem.cpp#L101

Since the Ring and the planet share the same center the shadow isn't casted onto the ring.

For fun I disabled this check and this came out of it: image

Schneegans commented 2 years ago

This doesn't look too bad after all :)

I think I have an idea how this could be fixed. Did you push your changes already?

JonasGilg commented 2 years ago

I think I have an idea how this could be fixed. Did you push your changes already?

Yes, they are on this branch: https://github.com/cosmoscout/cosmoscout-vr/tree/feature/ring-eclipses

Sadly I accidentally branched from the more-simple-bodies branch, so we shouldn't merge this before the other branch is merged.

Schneegans commented 2 years ago

I think we can close this now.