cosmoscout / cosmoscout-vr

:milky_way: A virtual universe which lets you explore, analyze and present huge planetary datasets and large simulation data in real-time.
Other
351 stars 27 forks source link

Ring eclipses #283

Closed Schneegans closed 2 years ago

Schneegans commented 2 years ago

This will need to be merged first: #280 .

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2454276504


Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/csp-atmospheres/src/Atmosphere.cpp 0 1 0.0%
plugins/csp-lod-bodies/src/LodBody.cpp 0 1 0.0%
plugins/csp-simple-bodies/src/SimpleBody.cpp 0 1 0.0%
src/cs-core/SolarSystem.cpp 0 1 0.0%
src/cs-core/EclipseShadowReceiver.cpp 0 3 0.0%
plugins/csp-rings/src/Ring.cpp 0 26 0.0%
<!-- Total: 0 33 0.0% -->
Files with Coverage Reduction New Missed Lines %
plugins/csp-rings/src/Ring.cpp 1 0%
src/cs-core/EclipseShadowReceiver.cpp 1 0%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 2433075108: -0.003%
Covered Lines: 496
Relevant Lines: 16466

💛 - Coveralls
Schneegans commented 2 years ago

Shall we merge this as well? Looks good to me.

JonasGilg commented 2 years ago

Shall we merge this as well? Looks good to me.

Do we want to add shading to the ring first?