Closed JonasGilg closed 2 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
plugins/csp-simple-bodies/src/Plugin.cpp | 0 | 2 | 0.0% | ||
plugins/csp-simple-bodies/src/SimpleBody.cpp | 0 | 6 | 0.0% | ||
<!-- | Total: | 0 | 8 | 0.0% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
plugins/csp-simple-bodies/src/SimpleBody.cpp | 1 | 0% | ||
src/cs-utils/DefaultProperty.hpp | 1 | 0% | ||
plugins/csp-simple-bodies/src/Plugin.cpp | 2 | 0% | ||
<!-- | Total: | 4 | --> |
Totals | |
---|---|
Change from base Build 2455163963: | -0.002% |
Covered Lines: | 496 |
Relevant Lines: | 16479 |
This looks great! I think you'll need to set mShaderDirty
to true if mPrimeMeridianInCenter
is changed. This could happen if configure()
is called (in repsonse to loading a new settings file, for example). So maybe you just call mShaderDirty = true;
in configure()
of the SimpleBody
.
I really like your choice of colors for the trajectories!
I took a color picker and picked the most dominant color from images from Wikipedia 😄
This adds 6 new moons:
It updates the textures of the following bodies (primarily with color):
Additionally a new option for a simple body was added, that determines if the texture has the prime meridian at the center. This makes it easier to integrate new textures without having to modify them.