Closed Schneegans closed 1 year ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
plugins/csp-lod-bodies/src/PlanetShader.cpp | 0 | 1 | 0.0% | ||
<!-- | Total: | 0 | 1 | 0.0% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
plugins/csp-anchor-labels/src/AnchorLabel.cpp | 1 | 0% | ||
<!-- | Total: | 1 | --> |
Totals | |
---|---|
Change from base Build 3180237718: | -0.0002% |
Covered Lines: | 491 |
Relevant Lines: | 16306 |
Is there a guideline for which file is licensed under which license? Because some config files are CC and others are MIT.
Is there a guideline for which file is licensed under which license? Because some config files are CC and others are MIT.
There should be no config files under CC-BY, however there are some under CC0.
There is no real guideline on when to choose which. However, there are two reasons due to which we may decide to publish a specific file under CC0 rather than MIT:
.gitignore
file etc. These files do not meet a certain "threshold of originality" and are therefore not really copyrightable (see here).Therefore, I put very simple files and our configuration files (not the vista xml's, they actually contain complex logic) under the CC0.
Thank you for the review! Why do we want to have newlines in those files? They are auto-generated anyways (via reuse addheader --copyright="German Aerospace Center (DLR) <cosmoscout@dlr.de>" --license="CC0-1.0" <binary file>
). I think it would be a bit cumbersome if we want to have those newlines everywhere...
Thank you for the review! Why do we want to have newlines in those files? They are auto-generated anyways (via
reuse addheader --copyright="German Aerospace Center (DLR) <cosmoscout@dlr.de>" --license="CC0-1.0" <binary file>
). I think it would be a bit cumbersome if we want to have those newlines everywhere...
Ok, I think we can leave it then. GitHub suggested these changes, so I went with it.
This makes CosmoScout VR compliant with the REUSE Specification of the Free Software Foundation Europe.
This requires #298 to be merged first.Some additional changes:
eslint
files were removed as we are usingclang-format
to format the JavaScript files.