coveralls
commented
1 year ago Pull Request Test Coverage Report for Build 3219511883
- 0 of 38 (0.0%) changed or added relevant lines in 11 files are covered.
- 5 unchanged lines in 2 files lost coverage.
- Overall coverage increased (+0.0006%) to 3.011%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| plugins/csp-anchor-labels/src/Plugin.cpp | 0 | 1 | 0.0% | ||
| plugins/csp-atmospheres/src/Plugin.cpp | 0 | 1 | 0.0% | ||
| plugins/csp-lod-bodies/src/Plugin.cpp | 0 | 1 | 0.0% | ||
| plugins/csp-sharad/src/Plugin.cpp | 0 | 1 | 0.0% | ||
| plugins/csp-stars/src/Plugin.cpp | 0 | 1 | 0.0% | ||
| plugins/csp-vr-accessibility/src/Plugin.cpp | 0 | 1 | 0.0% | ||
| plugins/csp-fly-to-locations/src/Plugin.cpp | 0 | 3 | 0.0% | ||
| plugins/csp-measurement-tools/src/Plugin.cpp | 0 | 3 | 0.0% | ||
| plugins/csp-wms-overlays/src/Plugin.cpp | 0 | 3 | 0.0% | ||
| plugins/csp-minimap/src/Plugin.cpp | 0 | 10 | 0.0% | ||
| <!-- | Total: | 0 | 38 | 0.0% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| plugins/csp-sharad/src/Plugin.cpp | 1 | 0% | ||
| src/cs-core/GuiManager.cpp | 4 | 0% | ||
| <!-- | Total: | 5 | --> |
| Totals | |
|---|---|
| Change from base Build 3188625428: | 0.0006% |
| Covered Lines: | 491 |
| Relevant Lines: | 16305 |
I think that this is going to be the last PR before we can publish 1.6.0!
With this PR, the interface of the
GuiManageris streamlined. Before, HTML templates could be added viaaddHtmlToGui()but had to be removed with an explicit JavaScript call. The same was true for adding and removing stylesheets. Here are all the changes:addScriptToGui()has been removed. It was never used and is actually identical togetGui()->executeJavascript()addScriptToGuiFromJS()has been renamed toexecuteJavascriptFileas this describes more clearly what the method actually does.addHtmlToGui()has been renamed toaddTemplate(), as this is what the method actually does.removeTemplate()has been added.addCssToGui()has been renamed toaddCSS().removeCSS()has been added.All plugins now use this updated API. Furthermore, some plugins have been simplified by moving their HTML templates to the sidebar HTML files. This reduces the number of required files and a few lines of code for registering and unregistering the templates.
Edit: I also explicitely download
clang-format-11for the formatting check. This way it's easier to reproduce the formatting locally.