Capture in meters - Githubissues

cosmoscout / cosmoscout-vr

:milky_way: A virtual universe which lets you explore, analyze and present huge planetary datasets and large simulation data in real-time.

Other

351 stars 27 forks source link

Capture in meters #316

Closed Schneegans closed 1 year ago

Schneegans commented 1 year ago

This fixes a regression which causes the depth images which can be captured with the csp-web-api plugin not to be in meters anymore. This was caused by our changed projection matrix.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3655211028

0 of 10 (0.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.002%) to 2.933%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
plugins/csp-web-api/src/Plugin.cpp	0	10	0.0%
<!--	Total:	0	10	0.0%	-->

Totals
Change from base Build 3513272209:	-0.002%
Covered Lines:	491
Relevant Lines:	16743

💛 - Coveralls

JonasGilg commented 1 year ago

The logic works flawless. I tested the distances "Moon" -> "Earth" and "Helgoland Beach" -> "Helgoland House" and came to the correct distances in meter.