Closed PdlAyush closed 1 year ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
plugins/csp-lod-bodies/src/TileSourceWebMapService.cpp | 0 | 11 | 0.0% | ||
<!-- | Total: | 0 | 11 | 0.0% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
plugins/csp-lod-bodies/src/TileSourceWebMapService.cpp | 1 | 0% | ||
<!-- | Total: | 1 | --> |
Totals | |
---|---|
Change from base Build 4700956288: | -0.0005% |
Covered Lines: | 193 |
Relevant Lines: | 16920 |
Thank you for your feedback, sorry for the two commits, the latest commit is absolutely not needed as I am just using TIFFGetField()
twice. Could you please only merge upto commit - 8bee368.
Thank you for implementing the changes. I think I cannot easily choose which commits to merge. Please undo the changes of that commit with a new commit. I'll will then squash-merghe this in the end.
Also, it would be great if you could add a note to the changelog for this bug fix (under "Bug Fixes" for the upcoming v1.8.0).
There are some scenarios where the error handling in (lines 69-76) is unable to detect and remove corrupt
.tiff
files in themap-cache
directory. I was able to create one such scenario by:std::this_thread::sleep_for ()
to create a delay before ourcurlpp::Easy request;
is performed. While doing so I get the error:The corrupt
.tiff
file wouldn't be removed. So the return ofTIFFGetField()
andTIFFReadScanline()
is checked to remove such corrupt.tiff
files.