cosmoscout / cosmoscout-vr

:milky_way: A virtual universe which lets you explore, analyze and present huge planetary datasets and large simulation data in real-time.
Other
347 stars 27 forks source link

Simple Bodies Ring Shadows #348

Closed JonasGilg closed 1 year ago

JonasGilg commented 1 year ago

Simple bodies can now be shaded by their ring. They take the same config as the csp-rings plugin.

https://github.com/cosmoscout/cosmoscout-vr/assets/9581540/5f034843-47b0-4903-a982-b10da7634177

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 5045802868


Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/csp-simple-bodies/src/Plugin.hpp 0 1 0.0%
plugins/csp-simple-bodies/src/Plugin.cpp 0 12 0.0%
plugins/csp-simple-bodies/src/SimpleBody.cpp 0 17 0.0%
<!-- Total: 0 30 0.0% -->
Files with Coverage Reduction New Missed Lines %
plugins/csp-simple-bodies/src/Plugin.cpp 2 0%
plugins/csp-simple-bodies/src/SimpleBody.cpp 2 0%
<!-- Total: 4 -->
Totals Coverage Status
Change from base Build 4881986019: -0.002%
Covered Lines: 193
Relevant Lines: 16994

💛 - Coveralls
Schneegans commented 1 year ago

Looks good. However, I do not understand what Clang complains about. Do you have an idea?

JonasGilg commented 1 year ago

Looks good. However, I do not understand what Clang complains about. Do you have an idea?

Seems like clang doesn't like the curly brace default initialization while specializing templates :thinking: