Closed JonasGilg closed 10 months ago
We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report. To ensure accuracy in future PRs, please see these guidelines. A quick fix for this PR: rebase it; your next report should be accurate.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
plugins/csp-sharad/src/Plugin.cpp | 0 | 1 | 0.0% | ||
plugins/csp-wms-overlays/src/WebMapTextureLoader.cpp | 0 | 1 | 0.0% | ||
src/cs-core/GuiManager.cpp | 0 | 2 | 0.0% | ||
src/cosmoscout/Application.cpp | 0 | 3 | 0.0% | ||
src/cs-gui/WebView.cpp | 0 | 3 | 0.0% | ||
src/cs-core/InputManager.cpp | 0 | 10 | 0.0% | ||
<!-- | Total: | 0 | 20 | 0.0% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
src/cs-core/InputManager.cpp | 2 | 0.0% | ||
plugins/csl-node-editor/src/Node.hpp | 12 | 0.0% | ||
plugins/csp-demo-node-editor/src/nodes/TimeNode.cpp | 13 | 0.0% | ||
plugins/csl-node-editor/src/NodeFactory.cpp | 19 | 0.0% | ||
plugins/csp-demo-node-editor/src/Plugin.cpp | 29 | 0.0% | ||
plugins/csl-node-editor/src/NodeEditor.cpp | 46 | 0.0% | ||
src/cs-core/SolarSystem.cpp | 166 | 0.0% | ||
<!-- | Total: | 287 | --> |
Totals | |
---|---|
Change from base Build 5463431705: | -0.001% |
Covered Lines: | 193 |
Relevant Lines: | 16602 |
Thank you very much for this impressive work! Everything seems to be working fine so far. However, when I run CosmoScout VR, I get these errors / warnings when loading the ini files:
But everything seems to be working nonetheless. Can we get rid of these warnings?
This looks very good to me. One last thing: Could you add a corresponding entry to the changelog?
This looks very good to me. One last thing: Could you add a corresponding entry to the changelog?
Done.
This PR replaces freeglut with SDL2 as a windowing toolkit, and input drivers. The main work is being done in Vista in the following PR: https://github.com/cosmoscout/vista/pull/24
One of the main features is a controller driver, which supports almost any controller that looks like a controller. Current feature support can be seen here: https://github.com/cosmoscout/vista/blob/feature/sdl-support/VistaCoreLibs/VistaDeviceDrivers/VistaSDL2ControllerDriver/README.md
I implemented a simple control scheme, that can be improved on in the future. Especially using the extended features of the PlayStation Controllers.